Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/cloud-native/issues#18: Soften messages for read-only extensionsDir #13100

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Improve messaging when someone has a different policy for managing extensionsDir. Most of the messaging update has already been done. There is only one message ("Read-Only Extensions"). It still encourages web-writable policy, but it lowers the severity and presents it a choice ("if you want X, do Y").

replaces #12623

Before

The message that is displayed is a warning when the directory is "Read-Only" which implies something is wrong.

After

The message that is displayed is a notice when the directory is "Read-Only". notice says it's merely out of the ordinary

Comments

This a continuation of this PR #11895.

dev/cloud-native#18

Giving merge-on-pass as a reviewer's commit

@civibot civibot bot added the master label Nov 15, 2018
@civibot
Copy link

civibot bot commented Nov 15, 2018

(Standard links)

@seamuslee001
Copy link
Contributor

Merging as per the tag

@seamuslee001 seamuslee001 merged commit 4ee2fc3 into civicrm:master Nov 15, 2018
@eileenmcnaughton eileenmcnaughton deleted the env branch November 15, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants