Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format type to Case Start and End Dates #13095

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

An "Undefined index: formatType" error prevents updating these fields properly- added a format type for these two values.

Replaces #13000

https://lab.civicrm.org/dev/core/issues/467

Before

before

After

after

Comments

Tested by @ray-wright with feedback "- the fields are now usable and update in the manner you'd expect them to."

@civibot
Copy link

civibot bot commented Nov 15, 2018

(Standard links)

@mattwire
Copy link
Contributor

@eileenmcnaughton Good to merge. #13000 has been reviewed and the only thing holding it up was the DAO needing to be regenerated properly, which you've done.

@eileenmcnaughton
Copy link
Contributor Author

thanks @mattwire

@eileenmcnaughton
Copy link
Contributor Author

@ray-wright I was able to keep you in the commit message :-)

@eileenmcnaughton eileenmcnaughton merged commit cb77b8a into civicrm:master Nov 15, 2018
@eileenmcnaughton eileenmcnaughton deleted the case_date branch November 15, 2018 11:18
@ray-wright
Copy link
Contributor

@eileenmcnaughton awesome!! My first contribution to core! Thanks @mattwire as well for help understanding how the DAO was generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants