dev/core#487 Menu cleanup in preparation for switch to SmartMenus library

[colemanw]

Overview

Code tweaks and cleanup to support the new SmartMenus based extension. Should have no impact otherwise.

Before

Messier code.

After

Cleaner code. No impact to existing sites.

Technical Details

• Add a couple client side variables
• Fix access to functions that were private for no reason
• Extract permissions check into its own function
• Fire crmLoad event when menu loads

See https://lab.civicrm.org/dev/core/issues/487

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@monishdeb please review (for NYSS).

[eileenmcnaughton]

I had some doubts about this going into 5.8 but there is some related stuff already merged which makes it kinda make sense to include. I discussed with @colemanw & tipped the balance by adding tests so I'm OK with it

[monishdeb]

I have tested the patch on all four CMSs (D8, D7, Joomla and Wordpress) esp. on menu build and its behaviour on permissions, and it worked like a charm. Rest assure, theres no intended regression due to the necessary cleanup change. Furthermore, added UT ensure that the new function CRM_Core_BAO_Navigation::checkPermission($menuItem) correctly access the permission of a menu item basis of different criteria:

1. w/o OR operator
2. Enabled/Disabled components
3. Permssion check

Thanks @colemanw for your work.

@lcdservices @eileenmcnaughton I am merging this PR on basis of:

• (r-explain) PASS
• (r-test) PASS
• (r-code) PASS
• (r-doc) PASS (PR description is good)
• (r-maint) PASS
• (r-run) PASS (test build passed, also checked on local)
• (r-user) PASS
• (r-tech) PASS