Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#372 Remove notice on activity update due to trying to proces… #13079

Merged
merged 1 commit into from
Nov 11, 2018
Merged

dev/core#372 Remove notice on activity update due to trying to proces… #13079

merged 1 commit into from
Nov 11, 2018

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Nov 9, 2018 •
edited by eileenmcnaughton
Loading

…s details key when non existant

Overview

When updating an activity that has no details set there is a notice error

To reproduce

  1. Login and create an activity but make sure you leave the details section blank
  2. View the activity
  3. Click to edit the activity and observe the undefined index error

Before

Notice error exists

After

No Notice error

ping @eileenmcnaughton @JoeMurray @colemanw

https://lab.civicrm.org/dev/core/issues/372

@civibot
Copy link

civibot bot commented Nov 9, 2018

(Standard links)

@civibot civibot bot added the master label Nov 9, 2018
@eileenmcnaughton
Copy link
Contributor

This is a safe change IMHO - merging

@eileenmcnaughton eileenmcnaughton merged commit e2669e8 into civicrm:master Nov 11, 2018
@eileenmcnaughton eileenmcnaughton deleted the lab_core_372 branch November 11, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton