dev/core#511 Fix wrong current month showing on Membership Dashboard #13072
Conversation
|
(Standard links)
|
CRM/Utils/Date.php
Outdated
| * the $format-formatted $date | ||
| */ | ||
| public static function customFormatTs($timestamp, $format = NULL, $dateParts = NULL) { | ||
| return CRM_Utils_Date::customFormat(date("Y-m-d H:i:s", $timestamp) , $format, $dateParts); |
There was a problem hiding this comment.
Maybe, the test is failing due to the extra space after ). Can you try removing that and ask jenkin to retest?
There was a problem hiding this comment.
Urgh! Stray spaces removed.
|
Not sure if we are in need of an additional function here. Same could be handled in But if this new function seems to be a good usage in future - Happy for this to merge as it fixes the main issue on Membership page as expected 👍 |
aydun
force-pushed
the
core511_membership_dashboard
branch
from
d22953b to
4b5f2d8
Compare
|
Agreed, it could be handled directly in the assign but the function seemed like it might be useful elsewhere. |
|
@aydun don't suppose we could get a test on that new function? |
Remove stray dash after Last Month name Add tests for new CRM_Utils_Date::customFormatTs() and existing CRM_Utils_Date::customFormat() dev/core#511
aydun
force-pushed
the
core511_membership_dashboard
branch
from
4b5f2d8 to
d2f262d
Compare
|
@eileenmcnaughton just for you :-) With a bonus test for the existing customFormat() fn |
|
@aydun so I requested a test well after you should have stopped working & you turned it around within an hour!!??!!??!! Merge on pass I say!! |
Overview
Correct the current month on the Membership Dashboard summary.
Before
Current month is wrong
After
Current month is right
Technical Details
Nothing much
Comments
https://lab.civicrm.org/dev/core/issues/511