Fix continue / break PHP 7.3 warnings

[ejegg]

Overview

PHP 7.3 emits warnings on ambiguous use of 'continue' where it
serves as a 'break' statement.

In all of these cases it looked like 'break' would have also worked
since there was nothing after the end of the switch statement but
before the end of the loop. But I used continue 2 to be a bit safer
about it, in case people add more code there.

Before

PHP 7.3 emits warnings, causing tests to fail under strict conditions

After

Fewer warnings

Technical Details

If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary

Comments

Note that in the contact Query there seems to be a fallthrough bug
with campaign, where a comment says things not matching the tested
cases should fall through to default, but 'website' has been added
in between.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@ejegg What do you think about extracting the big switch clause instead? for the first one e.g something like

      $from = $from . self::getFromClauseForField($mode, $name, $side, $primaryLocation);

where the extracted function looks like

  /**
   * @param $mode
   * @param $name
   * @param $side
   * @param $primaryLocation
   *
   * @return string
   */
  protected static function getFromClauseForField($mode, $name, $side, $primaryLocation) {
    $limitToPrimaryClause = $primaryLocation ? "AND {$name}.is_primary = 1" : '';
    switch ($name) {
      case 'civicrm_address':
        //CRM-14263 further handling of address joins further down...
        return " $side JOIN civicrm_address ON ( contact_a.id = civicrm_address.contact_id {$limitToPrimaryClause} )";

      case 'civicrm_phone':
        return " $side JOIN civicrm_phone ON (contact_a.id = civicrm_phone.contact_id {$limitToPrimaryClause}) ";

[eileenmcnaughton]

Looking at the code I think this one should be a 'break'

[eileenmcnaughton]

I think this should probably be a break too

[ejegg]

Ah, cool, I like the thought of extracting the whole thing

[ejegg]

OK, updated to use 'break' in the CustomGroup and PriceSet, and to extract the function more or less like you suggested

[ejegg]

Ahh, whitespace warnings from checkstyle. I'll fix those, and pull the extra line into the function

[ejegg]

test this please

[eileenmcnaughton]

I re-did the same extraction & compared any differences between my result & this result & they were all cosmetic. Tests coverage is good over this code & approach is sensible. Merging.

yay to supporting php 7.3