Fix help for financial acls. #13053
Merged
Fix help for financial acls. #13053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seamuslee001
reviewed
Nov 4, 2018
seamuslee001
reviewed
Nov 4, 2018
| @@ -48,7 +48,7 @@ | |||
| 'is_contact' => 0, | |||
| 'description' => ts('This feature allows users to register for more than one event at a time. When enabled, users will add event(s) to a "cart" and then pay for them all at once. Enabling this setting will affect online registration for all active events. The code is an alpha state, and you will potentially need to have developer resources to debug and fix sections of the codebase while testing and deploying it'), | |||
| 'help_text' => '', | |||
| 'help_link' => ['page' => 'CiviEvent Cart Checkout', 'resource' => 'wiki'], | |||
| 'documentation_link' => ['page' => 'CiviEvent Cart Checkout', 'resource' => 'wiki'], | |||
There was a problem hiding this comment.
@eileenmcnaughton and here too
eileenmcnaughton
force-pushed
the
settings_help
branch
from
29c78b8 to
37fb2c3
Compare
|
@seamuslee001 fixed |
seamuslee001
reviewed
Nov 4, 2018
templates/CRM/Core/Form/Field.tpl
Outdated
| @@ -35,6 +35,6 @@ | |||
| </td> | |||
| <td>{if $form.$fieldName.html}{if $fieldSpec.formatter === 'crmMoney'}{$form.$fieldName.html|crmMoney}{else}{$form.$fieldName.html}{/if}{else}{$fieldSpec.place_holder}{/if}<br /> | |||
| {if $fieldSpec.description}<span class="description">{$fieldSpec.description}</span>{/if} | |||
| {if $fieldSpec.documentation_link}{docURL page=$fieldSpec.documentation_link.page}{/if} | |||
| {if $fieldSpec.documentation_lCink}{docURL page=$fieldSpec.documentation_link.page resource=$fieldSpec.documentation_link.resource}{/if} | |||
There was a problem hiding this comment.
@eileenmcnaughton typo
There was a problem hiding this comment.
argh it must have recorded a key stroke in the wrong window
I've done this by using the field template that is used by entity forms & adding help to the spec (which I'll document). I noted in this that entityTrait used a different field key for the documentation link - literally documentation_link whereas I had used field_link so I fixed settings to match
eileenmcnaughton
force-pushed
the
settings_help
branch
from
37fb2c3 to
969afb1
Compare
|
After re-testing (manually fixing the typo) I can confirm all links work and the ACL help is correct adding merge on pass |
|
thanks @seamuslee001 |
|
Merging as per the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow up fix on #13047 to get help text on financial acls working on contribution settings page (addresses temporary regression in master / unreleased code)
Before
After
Technical Details
To test this make sure you do a cv flush or similar since setting metadata is cached - also the help text is slow to load locally - not sure why but don't give up :-) (this is not a new slowness)
@mattwire @pradpnayak this is kind of exciting
I've done this by using the field template that is used by entity forms & adding
help to the setting spec (which I'll document).
I noted in this that entityTrait used a different field key for the
documentation link - literally documentation_link whereas I had used field_link
so I fixed settings to match
Comments
Remaining todo list
address the help text issue