dev/core#500 Fix CiviCase Dashboard Summary Count to not include cases from inactive relationships

[mlutfy]

https://lab.civicrm.org/dev/core/issues/500

Overview

How to reproduce:

• Create a case
• Assign it to someone, view their dashboard, it will show X cases
• Then re-assign it to someone else, view their dashboard, it will still show X cases (instead of X-1).

Technical Details

The SQL query had forgotten to filter on case_relationship.is_active = 1.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@lcdservices could you review this?

[lcdservices]

@mlutfy Can you clarify -- when you say "view their dashboard" -- do you mean the My Cases dashlet on the CiviCRM Home dashboard? The Case Dashboard Dashlet on the CiviCRM Home dashboard? Or the Case Dashboard?

What I'm seeing is that on the Case Dashboard page, the summary of involvement now correctly reflects the number of cases assigned to the user. But the My Cases with Upcoming Activities and My Cases with Recently Performed Activities still return the reassigned case -- as does the My Cases dashlet on the CiviCRM Home page.

So this appears to fix part of the issue, but not the entire issue.

[mattwire]

@mlutfy As #13134 includes this fix could you confirm if you are happy with that PR and then we can close this one in favour of #13134

[mlutfy]

Yep, thanks, closing!