Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#491) Report results don't show inactive campaigns #13036

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

yashodha
Copy link
Contributor

Overview

Report results don't show inactive campaigns. The results can be searched properly via Find Contributions.

Before

find_camp
camp_before

After

camp_after

@civibot
Copy link

civibot bot commented Oct 30, 2018

(Standard links)

@civibot civibot bot added the master label Oct 30, 2018
@alifrumin
Copy link
Contributor

alifrumin commented Oct 30, 2018

I tested this pr and think it is ready to be merged.

I tested by:

On the site created by jenkins:

  1. Enabling the civiCampaign Component
  2. Creating a campaign
  3. Creating a contribution for a contact for that campaign
  4. Disabling the campaign
  5. Running the contribution details report with the campaign column checked, see screenshot of the contribution showing up as expected below:

inactivecampaign

@eileenmcnaughton
Copy link
Contributor

merging based on @alifrumin review

@eileenmcnaughton eileenmcnaughton merged commit 899f47b into civicrm:master Oct 31, 2018
@yashodha
Copy link
Contributor Author

@alifrumin @eileenmcnaughton thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants