CRM-21677 - more report clean up #13028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
I agree this does not change the sql at all |
|
Can you use an arrow on the images to point to what changes? Or even a text description? They look the same to me, but then I should be wearing glasses more. ;) |
|
@JoeMurray check the code - there is no change in the UI - the screenshots just demonstrate that |
|
Ah. So I don't need to go see an optometrist. Good. ;) |
|
Re-test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
in continuation of #12698
Before
After
Comments
The card type field from table civicrm_financial_trxn in the results is coming as a result of this join.