Fix notices on mailing components screen, convert to metadata based

[eileenmcnaughton]

Overview

Fix notices in warnings on Mailing component settings screen in unreleased version of CiviCRM

Before

After

Technical Details

Recent work to synchronize our arbitrarily different 'settings' forms & 'preferences' forms hadn't covered 'checkbox' fields yet & the Mailing settings form was looking ugly. I have done the work to cope with the checkbox fields now & also extended it to the 4 checkboxes on the 'Display Preferences' form.

I'm looking that the rest of the preferences forms with the intention of fixing any ugliness before the rc is cut. Currently to do is

1. Fix contribution preferences form Fix Contribution settings form per dev/core/473 #13022
2. Fix multisite preferences form - the challenge here is handling the doc2Link part - will need a metadata addition - see Fix notices on Multisite settings form #13025
3. CiviCampaign Component Settings form Fix notices on Campaign preferences form #13026
4. Event preferences form - same doclink issue, small settings tweak for fixed option values for the other setting Fix notices on event settings form #13027
5. work through full address preferences Fix notices on Campaign preferences form #13026
6. work through remaining display preferences Convert final settings on the Display form #13040

• the above all deals with notices - once done cleanup includes

1. hack out remaining references to $_varNames in all the above except contribution preferences form
2. Return the special handling for invoice_settings to the contribution preferences form
3. entirely remove Preferences form class

• heaps more but I think that would end this round

Comments

@mattwire @kcristiano ping

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

I have tested this and confirmed it fixes the e-notices and confirmed the settings are still correct.