Translate description in DAO files #13005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relates to the attempt here civicrm#12971 to use description directly in the Entity Forms & questions as to whether it is translated. Currently they are not but there seems like no downside in translating them
|
(Standard links)
|
|
I don't have a concern with this |
|
My only concern is that it adds addnl burden for translators to translate a bunch of (currently) unused strings. |
|
@colemanw I guess the mitigating factor there is it allows us to sync up the schema & form descriptions & start to only maintain the schema one |
|
Caved into the peer/time pressure :) |
|
lol - I'll merge #12971 then |
|
I like this idea and am happy to see this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Translate description in DAO files
Before
Description field not translated in DAO descriptions - this would only really be apparent when calling the getfields api.
After
Description field translated in DAO descriptions
Technical Details
This relates to the attempt here #12971
to use description directly in the Entity Forms & questions as to whether it is translated.
Currently they are not but there seems like no downside in translating them
Comments
@mattwire @seamuslee001 @colemanw @mlutfy @totten can anyone think of any downsides of doing this.
(note this will go stale quickly)