Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Event Participant Registration Date to datepicker #12979

Merged

Conversation

mattwire
Copy link
Contributor

Overview

Convert form to use datepicker:

  • Register Participant - Registration Date

Partial from #12973

Before

Using old jcalendar.

After

Using "new" datepicker.

@civibot
Copy link

civibot bot commented Oct 21, 2018

(Standard links)

@colemanw
Copy link
Member

I can confirm this works in the UI, but CRM_Event_Form_ParticipantTest tests will need to be updated as this is causing failures.

@mattwire mattwire changed the title Convert Event Participant Registration Date to datepicker WIP Convert Event Participant Registration Date to datepicker Oct 21, 2018
@mattwire mattwire force-pushed the datepicker_eventparticipant_register branch from bf450a9 to 6ba1830 Compare October 23, 2018 21:24
@seamuslee001
Copy link
Contributor

@mattwire should this still be WIP?

@eileenmcnaughton
Copy link
Contributor

49 instances of jcalendar left...

@seamuslee001 seamuslee001 changed the title WIP Convert Event Participant Registration Date to datepicker Convert Event Participant Registration Date to datepicker Oct 25, 2018
@seamuslee001
Copy link
Contributor

Removed WIP as it seems Matt has fixed the problem with the tests, Based on Coleman's review and the tag i'm going to merge this

@seamuslee001 seamuslee001 merged commit b7801a4 into civicrm:master Oct 25, 2018
@mattwire
Copy link
Contributor Author

@seamuslee001 Thanks, think I was waiting for the tests to pass, but seeing as they did 👍

@mattwire mattwire deleted the datepicker_eventparticipant_register branch October 25, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants