Fix (unreleased) fatal error on contribution preferences settings page

[eileenmcnaughton]

Overview

Recent changes to the display preferences page have caused an unreleased regression on the civicontribute preferences page. This fixes the regression but there are still some warnings for a follow up

Before

Page gives fatal rather than load

After

Page loads

Technical Details

Settings.getoptions supports a lesser format-set to CRM_Core_DAO::buildOptions does
in terms of pseudoconstant keys. Ideally we would fix that but for now
fix the fatal on the contribution page settings page by using
a format that is supported

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@mattwire ....

[pradpnayak]

Thanks @eileenmcnaughton for the fix. The changes look good to me. I agree we need to handle Pseudo-constant for settings as we need to add callback function for every settings. Probably using buildOptions() to build this? But we need to retain callback function for some use-cases. Thoughts?

Good to merge!

[eileenmcnaughton]

@pradpnayak ideally we should support exactly the same options in the pseudoconstant key as the dao / schema xml does - it will have to be a todo for now though.

Merging based on your review