Intelligently adjust menubar for D7 toolbar toggle

[colemanw]

Overview

Civi menubar was being set to width 97% to make room for the Drupal Toolbar toggle. The 2 problems with that are:

• 97% is imprecise - what we really wanted was 100% minus the width of the toolbar toggle.
• Some Drupal sites do not use the toolbar module.

Before

Civi menubar set to width 97% unconditionally.

After

Civi menubar set to 100% minus the width of the toolbar toggle, but only if the toolbar toggle is actually present on the screen.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw this makes sense - do you know of a case when the if would be false?

[homotechsual]

(CiviCRM Review Template DEL-1.1)

• Explain (r-explain)

  • UNREVIEWED
  • COMMENTS: Change seems simple enough without explanation however this link provides the context: https://chat.civicrm.org/civicrm/pl/5uh3133bxfd33m3xa3xjpwzaxc
    Gitlab, StackExchange).

• Test results (r-test)

  • PASS: The test results have failures, but these have been individually inspected and found to be irrelevant.

• Code quality (r-code)

  • PASS: The functionality, purpose, and style of the code seems clear+sensible.

• Documentation (r-doc)

  • PASS: The changes do not require documentation.

• Maintainability (r-maint)

  • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests.

• Run it (r-run)

  • PASS: Ran on CiviCRM 5.6.0 with the following combinations:
    • With Shoreditch with the Admin Menu module - Civi menu is full width.
    • With Shoreditch without the Admin Menu module - Civi menu has gap to show the expander/toggle.
    • With Shoreditch without the Admin Menu module with the core Toolbar module disabled - Civi menu is full width.
    • Without Shoreditch with the Admin Menu module - Civi menu is full width.
    • Without Shoreditch without the Admin Menu module - Civi menu has gap to show the expander/toggle.
    • Without Shoreditch without the Admin Menu module with the core Toolbar module disabled - Civi menu is full width.

• User impact (r-user)

  • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.

• Technical impact (r-tech)

  • PASS: The change preserves compatibility with existing callers/code/downstream.

[homotechsual]

this makes sense - do you know of a case when the if would be false?

@eileenmcnaughton the if will return false if the core toolbar module is disabled or if the admin_menu module is being used instead.

[eileenmcnaughton]

Thanks for the review @MikeyMJCO really helpful