Status page: hush menu should be on top of other headers #12936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tempered a bit of z-index overkill on the
<li>
elements in the menuOverview
On statuses with short messages, the menu to hush the status for a week/month/forever overlaps the next status header. The menu should be on top of the header both for legibility and in order to click the last option.
Before
The next header is on top of the bottom of the menu. You cannot select the last option.
![overlapping menu](https://user-images.githubusercontent.com/1682375/46966070-9fc6e600-d07a-11e8-8050-34b5f59b5a59.png)
After
The menu is on top of the next header.
![overlapping menu fixed](https://user-images.githubusercontent.com/1682375/46966211-09df8b00-d07b-11e8-9f11-bc02999cd915.png)
Technical Details
I set the z-index on the
<ul>
element. The constituent<li>
elements had a z-index of99999
, which was excessive (it would appear on top of a modal, for example), so I dropped that down to99
to allow some room for other things to go above it if necessary. These numbers aren't magical; I just want to avoid a z-index arms race.