Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status page: hush menu should be on top of other headers #12936

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

agh1
Copy link
Contributor

@agh1 agh1 commented Oct 15, 2018

Also tempered a bit of z-index overkill on the <li> elements in the menu

Overview

On statuses with short messages, the menu to hush the status for a week/month/forever overlaps the next status header. The menu should be on top of the header both for legibility and in order to click the last option.

Before

The next header is on top of the bottom of the menu. You cannot select the last option.
overlapping menu

After

The menu is on top of the next header.
overlapping menu fixed

Technical Details

I set the z-index on the <ul> element. The constituent <li> elements had a z-index of 99999, which was excessive (it would appear on top of a modal, for example), so I dropped that down to 99 to allow some room for other things to go above it if necessary. These numbers aren't magical; I just want to avoid a z-index arms race.

Also tempered a bit of z-index overkill on the `<li>` elements in the menu
@civibot
Copy link

civibot bot commented Oct 15, 2018

(Standard links)

@civibot civibot bot added the master label Oct 15, 2018
@mattwire
Copy link
Contributor

@vingle Principal seems fine. Any thoughts?

@colemanw
Copy link
Member

Looks good to me.

@vingle
Copy link
Contributor

vingle commented Oct 15, 2018

It worked for me (long time since I've seen a "font-size: smaller" property!)

@eileenmcnaughton
Copy link
Contributor

test fails unrelated

@eileenmcnaughton eileenmcnaughton merged commit ec5442f into civicrm:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants