Added further tests for process_membership job: check status for inherited memberships #12927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton The next instalment! |
davejenx
changed the title
|
@davejenx there is a style issue |
|
@eileenmcnaughton Oops, accidentally committed cherry-picked stuff too, please don't merge until I've fixed! |
|
OK, that's reverted now. Think we're OK. |
|
@davejenx - do you want to rebase -i to drop them out & squash the patches? |
|
@eileenmcnaughton I'm not familiar with how that's done. |
… updated correctly for inherited membership. In function testProcessMembershipUpdateStatus.
davejenx
force-pushed
the
job_process_memberships_test_inherit
branch
from
90ffef0 to
0c6bcd7
Compare
|
@eileenmcnaughton Howzat? |
|
spot on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added further checks for process_membership job: check that status is updated correctly for inherited membership. In function testProcessMembershipUpdateStatus.
Before
No tests for inherited membership processing.
After
Tests for inherited membership processing.
Technical Details
In existing function testProcessMembershipUpdateStatus.
Comments
Test was failing during development with inherited membership being deleted. Tracked this down to a static variable in CRM_Member_BAO_Membership::createRelatedMemberships(). There is a reset parameter for this static, so I used that to work around the problem. The issue should not occur outside tests. An alternative approach would be to replace the static variable with Civi::$statics but note reset facility is used elsewhere: CRM-17723. See CRM-4213, CRM-19735.