-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate various settings information #12919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Standard links)
|
mattwire
reviewed
Oct 10, 2018
settings/Core.setting.php
Outdated
'is_domain' => 1, | ||
'is_contact' => 0, | ||
'description' => 'Maximum Size of file (documents, images, etc.) which can attached to emails or activities.<br />Note: php.ini should support this file size.', | ||
'description' => ts('Maximum Size of file (documents, images, etc.) which can attached to emails or activities.<br />Note: php.ini should support this file size.'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be attached
mattwire
reviewed
Oct 10, 2018
settings/Core.setting.php
Outdated
'is_domain' => 1, | ||
'is_contact' => 0, | ||
'description' => 'Maximum number of files (documents, images, etc.) which can attached to emails or activities.', | ||
'description' => ts('Maximum number of files (documents, images, etc.) which can attached to emails or activities.'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be attached
eileenmcnaughton
force-pushed
the
setting
branch
from
October 10, 2018 13:45
573d672
to
732b1d0
Compare
Merge on pass |
Jenkins re test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Translate settings information
Before
Settings info untranslated (e.g in api explorer)
After
Settings info translated. Some wording tweaks.
Technical Details
Comments