GL-425: Log a message if CiviCRM thinks SSL is not enabled #12908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The enableSSL setting doesn't reliably detect the presence of SSL (especially when behind SSL terminating proxies). This log message will allow people affected by this behaviour to more readily debug it, because CiviCRM will give them a clue to work with.
See https://lab.civicrm.org/dev/core/issues/425
Before
CiviCRM behind an SSL-terminating proxy may misdetect SSL and generate circular 302s to the current URL for any path below
civicrm/admin
.After
CiviCRM will still do that until you disable "Force Secure URLs", but at least it'll put a clue in the debug log.
Technical Details
Only behaviour change should be addition of the warning message to log.
Comments
See https://lab.civicrm.org/dev/core/issues/425 😁