Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-425: Log a message if CiviCRM thinks SSL is not enabled #12908

Merged

Conversation

xurizaemon
Copy link
Member

Overview

The enableSSL setting doesn't reliably detect the presence of SSL (especially when behind SSL terminating proxies). This log message will allow people affected by this behaviour to more readily debug it, because CiviCRM will give them a clue to work with.

See https://lab.civicrm.org/dev/core/issues/425

Before

CiviCRM behind an SSL-terminating proxy may misdetect SSL and generate circular 302s to the current URL for any path below civicrm/admin.

After

CiviCRM will still do that until you disable "Force Secure URLs", but at least it'll put a clue in the debug log.

Technical Details

Only behaviour change should be addition of the warning message to log.

Comments

See https://lab.civicrm.org/dev/core/issues/425 😁

The enableSSL setting doesn't reliably detect the presence of SSL (especially
when behind SSL terminating proxies). This log message will allow people
affected by this behaviour to more readily debug it, because CiviCRM
will give them a clue to work with.

See https://lab.civicrm.org/dev/core/issues/425
@civibot
Copy link

civibot bot commented Oct 9, 2018

(Standard links)

@civibot civibot bot added the master label Oct 9, 2018
@eileenmcnaughton
Copy link
Contributor

Thanks @xurizaemon - agree this is helpful & understand that a bigger fix would be a scope blow out

@eileenmcnaughton eileenmcnaughton merged commit 7927c4c into civicrm:master Oct 9, 2018
@xurizaemon
Copy link
Member Author

Yes, that's why I opened the issue hoping for discussion on how to address it more completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants