Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On reports make current employer available as a field for display #12904

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

yashodha
Copy link
Contributor

@yashodha yashodha commented Oct 8, 2018

Overview

Expose current employer in fields and display in results as well. I think this was supported earlier.

Before

rep_before

After

rep_after
result_after

@civibot civibot bot added the master label Oct 8, 2018
@civibot
Copy link

civibot bot commented Oct 8, 2018

(Standard links)

@eileenmcnaughton eileenmcnaughton changed the title expose current employer in fields and display in results as well On reports make current employer available as a field for display Oct 8, 2018
@totten
Copy link
Member

totten commented Oct 9, 2018

Aside/short term tip for reviewers -- The link for the "test sites" above points at an old server. Fixing the bot is a TODO; in the interim, you should be able to edit the link a little to get to the right page:

Note how the test-ubu1204-5 changes to test-1.

@Clairepickle
Copy link

Tested on demo site and works as expected

@eileenmcnaughton
Copy link
Contributor

merging based on @Clairepickle testing. Code looks sensible & non-risky

@eileenmcnaughton eileenmcnaughton merged commit fa00ff9 into civicrm:master Oct 9, 2018
@yashodha
Copy link
Contributor Author

@Clairepickle @eileenmcnaughton thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants