Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NFC) Make datatables in Activities Relationship tab adjust to screen size #12893

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

samuelsov
Copy link
Contributor

Overview

Cosmetic changes to make datatables in Activities and Relationship tab behave like the membership tab, i.e. the table adjust as much as possible to the size of the screen.

Before

In Activities tab, the size is properly initialized but when resizing the window, it keeps the original size:
activity-before

In Relationship tab, it doesn't initialize properly and doesn't follow the window size:
relationship-before

After

In Activities tab:
activity-after

In Relationships tab:
relationship-after

Technical Details

Added style="width: 100%; " as suggested in https://datatables.net/examples/basic_init/flexible_width.html

@civibot
Copy link

civibot bot commented Oct 3, 2018

(Standard links)

@civibot civibot bot added the master label Oct 3, 2018
@samuelsov
Copy link
Contributor Author

The check fail has nothing to do with the PR, i.e. just in a small UI change.

@eileenmcnaughton
Copy link
Contributor

@mattwire thoughts on this one?

@mattwire
Copy link
Contributor

mattwire commented Oct 6, 2018

Ok tested. Before=rubbish. After=better. Please merge

@eileenmcnaughton
Copy link
Contributor

test fails unrelated - merging per @mattwire review

@eileenmcnaughton eileenmcnaughton merged commit 5ab84d5 into civicrm:master Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants