Added missing field name in custom-field deletion dialog

[dereklewis123]

Overview

The dialog that pops up when a custom field is deleted, does not show the name of the field to be deleted.

Before

The name of the field in the deletion dialog box was missing.

After

The name of the field in the deletion dialog box is now visible.

[civicrm-builder]

Can one of the admins verify this patch?

[mattwire]

I've tested this, it's a minor UI bug and assigning an extra variable to the template fixes it. Merge on pass @seamuslee001

[colemanw]

@civicrm-builder add to whitelist

[JKingsnorth]

Jenkins retest this please

[seamuslee001]

Removed the Merge on pass as per @JKingsnorth

[JKingsnorth]

I agree with @mattwire that this does fix the issue and is good to merge when the tests are fixed (the failures seem unrelated).

[eileenmcnaughton]

test this please

[totten]

jenkins, test this please

[totten]

Congratulations on the first PR! Thanks for the well-formed description.

Also, thanks to the sprinters at Bamford for the group review. The well-formed description on this PR made it really helpful as a group-training discussion.

(CiviCRM Review Template DEL-1.1)

• Explain (r-explain)
  • PASS : The goal/problem/solution have been adequately explained in the PR.
• Test results (r-test)
  • PASS: The test results have failures, but these have been individually inspected and found to be irrelevant.
• Code quality (r-code)
  • PASS: The functionality, purpose, and style of the code seems clear+sensible.
• Documentation (r-doc)
  • PASS: The changes do not require documentation.
• Maintainability (r-maint)
  • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests.
• Run it (r-run)
  • PASS: Attempted to delete a stock custom-field ("Camera Skill Level") from a demo site. The patch fixes the display as expected.
• User impact (r-user)
  • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
• Technical impact (r-tech)
  • PASS: The change preserves compatibility with existing callers/code/downstream.