Fix default value of civicrm_option_group.is_locked in DB schema
#12861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed this is the correct fix. It matches what the SQL describes. Good to merge |
|
Shouldn't this be against 5.6? |
eileenmcnaughton
force-pushed
the
locked
branch
from
f9cd8d0 to
88542a5
Compare
totten
changed the title
civicrm_option_group.is_locked in DB schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The 5.5 update set civicrm_option_group.is_locked & is_reserved to have a db defaults but the upgrade script was incorrect on is_locked
Before
Newly created option groups (e.g for custom fields) are set to is_locked
After
Newly created option groups (e.g for custom fields) are not set to is_locked
Technical Details
The default for new instals was correct
Comments
@seamuslee001