Fix missing amount in soft credit mode #12860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eileenmcnaughton should this be against the 5.6 branch? |
|
I beat you there |
|
@twomice are you able to review this? |
|
Adding merge on pass |
eileenmcnaughton
force-pushed
the
report56
branch
from
63dff79
to
34634fd
Compare
|
Just confirming following latest patch i can confirm the report issue is still fixed |
|
Test Failures unrelated Merging per the tag and my review |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix missing non-display of soft credit amount in detail report
Before
Field empty, untested
After
Field populated, test added.
Technical Details
The contribution detail report is fundamentally badly designed in how it melds the soft credits with the contribution details & although we have now brought in under unit tests we are still dealing with whack-a-mole on it (& have been for many many many months). We are adding unit tests now as we fix these things.
Comments
https://lab.civicrm.org/dev/core/issues/386
@twomice @lcdservices can you test?