Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#346 - 5.5 submission for 12745 #12777

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

jitendrapurohit
Copy link
Contributor

Overview

5.5 submission of #12745. Details on the original PR.

@magnolia61
Copy link
Contributor

I tested this PR and it works as expected. When the user dashboard is accessed by a checksum link it add a checksum link to the Pay Now button url.

@totten
Copy link
Member

totten commented Sep 5, 2018

@seamuslee001 pinged me about this b/c there's some special circumstance for merging. It's about time to ship 5.5.0, but the automated test system is currently offline (pending a system rebuild). It seems OK to merge anyway because:

  1. This is a appear to be a backport that was more fully reviewed in the prior PR.
  2. There's been some manual testing on both the original and the backport.
  3. Even if the automated tests ran, they don't provide much coverage for this content.

@totten totten merged commit b9ff6e6 into civicrm:5.5 Sep 5, 2018
seamuslee001 added a commit to seamuslee001/civicrm-core that referenced this pull request Sep 5, 2018
totten added a commit that referenced this pull request Sep 5, 2018
(NFC) Update 5.5 Release notes to take into account pr #12777
seamuslee001 added a commit to seamuslee001/civicrm-core that referenced this pull request Sep 5, 2018
@jitendrapurohit jitendrapurohit deleted the core-346-rc branch September 6, 2018 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants