Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom data display on MembershipType form #12738

Conversation

mattwire
Copy link
Contributor

Overview

Enable display of custom data on MembershipType form.

Before

Custom fields not displayed on MembershipType form

After

If MembershipType custom fields are configured it is displayed on MembershipType form:
localhost_8000_civicrm_admin_member_membershiptype_reset 1

Technical Details

Just a template change as all the other required changes have already been made.

Comments

@eileenmcnaughton Are we ok to merge this now? I know you'd like to do some more work on the MembershipType form but I think both you and I have other priorities at the moment, we've made some quite significant improvements on this form and it's probably worth focussing efforts elsewhere for now?

@civibot
Copy link

civibot bot commented Aug 28, 2018

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Alright - I'm not keen on setting a precedent - but let's be done with it

@eileenmcnaughton eileenmcnaughton merged commit 5ddc0e8 into civicrm:master Aug 28, 2018
@mattwire
Copy link
Contributor Author

@eileenmcnaughton Thankyou :-) I'll keep trying to catch up and review some more of yours

@mattwire mattwire deleted the membershiptype_customdata_formsupport branch September 25, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants