Remove mcrypt warning except for affected sites.

[eileenmcnaughton]

Overview

We have a system check that warns people if mcrypt is not available. This refines that to only warn affected sites - ie. ones that have their smtp password stored in the database. There are no other places that core uses encryption so it's not appropriate for people to get messages if they are unaffected.

Before

Site on php 7.2 gets encryption warning, regardless of whether they have stored smtp passwords

After

Site on php 7.2 (or other site without mcrypt) only gets warning if they have stored smtp passwords

Technical Details

Extensions that wish to have a version of this should implement it themselves as
it is basically pretty trivial & it doesn't make sense to spam non-affected people

Comments

I also altered the wording as our php version recommendations have changed we no longer actively recommend mcrypt

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

Conceptual 👍. It reduces noise for unaffected configurations.

[seamuslee001]

i agree with the change, I assume the question for me is if we aren't advocating mcrypt then what is the solution?

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@seamuslee001 good question :-) I expressed my thoughts on #12697 (which basically add up to - this doesn't have to be solved in core )

[colemanw]

I'm happy with this too.