dev/core#352 Ensure that contacts that are to be exluded are not adde… #12712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
monishdeb
reviewed
Aug 27, 2018
CRM/Mailing/BAO/Mailing.php
Outdated
| @@ -282,8 +282,10 @@ public static function getRecipients($mailingID) { | |||
| // Get recipients selected in prior mailings | |||
| if (!empty($priorMailingIDs['Include'])) { | |||
| CRM_Utils_SQL_Select::from('civicrm_mailing_recipients') | |||
| ->select("contact_id, $entityColumn") | |||
| ->select("civicrm_mailing_recipients.contact_id, $entityColumn") | |||
There was a problem hiding this comment.
can you also add DISTINCT to select clause mostly on queries which involve temp table? because lately I encountered a issue that temp table are populated with duplicate entries and this causes performance issue in menu rebuild
There was a problem hiding this comment.
@monishdeb sure
There was a problem hiding this comment.
As you can see here the old code got DISTINCT in select clauses and this change has been lost during refactoring :(
There was a problem hiding this comment.
@monishdeb added now
…d incorrectly when adding recipients of past mailings Add in DISTINCT clause as per Moonish's comment
seamuslee001
force-pushed
the
dev_core_352
branch
from
3b34d0e to
e3d924c
Compare
|
OK I took a look through this & per @seamuslee001 the exclude join is present in other places, just not this one. Merging. Yay test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d incorrectly when adding recipients of past mailings
Overview
When using recipients from a previous mailing as the recipients of a mailing. If any exclusion groups / mailings. The contacts in these are groups / mailings are not properly removed when adding the recipients of the mailing for inclusion.
Before
Contacts wrongly included in emails when previous mailing used as the inclusion
After
Contacts not wrongly included and unit test added
ping @eileenmcnaughton @monishdeb @totten @andrew-cormick-dockery @jtwyman