-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact summary - adjust block width when editing #12708
Conversation
(Standard links)
|
d401f50
to
1f4e57d
Compare
@tschuettler thanks for the review. I've tweaked the code to rely more on css and less on javascript, and the result is more flexible. It now wraps help text correctly, responds to width changes when the form needs to expand to show something like a delete button, and responds pretty well to the window being resized mid-edit. Give it another try :) |
Thanks again for the thorough testing @tschuettler! Glad you haven't been able to break it :) |
@colemanw I implemented and tested in shoreditch -- looks great. I think this is a big improvement. |
Overview
Fixes an annoyance when editing blocks on the contact summary screen where their content would be hidden with a scrollbar.
Before
Forms that were too wide would be cropped and need to be manually scrolled.
After
Forms will auto-adjust their width to fit content.
Notes
Compatible with Shoreditch and Contact Summary Layout Editor extensions.