Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#349 correct default sort for scheduled reminders list #12701

Merged

Conversation

magnolia61
Copy link
Contributor

@magnolia61 magnolia61 commented Aug 20, 2018

Overview

The Scheduled Reminder list default sort does not work because of a small typo.
This PR corrects that.

Before

The Scheduled Reminder list default sort does not work

After

The Scheduled Reminder list default sort works for the title collumn

Technical Details

class="sortable" was used. But id="sortable" should have been used

https://lab.civicrm.org/dev/core/issues/349

@civibot
Copy link

civibot bot commented Aug 20, 2018

(Standard links)

@eileenmcnaughton
Copy link
Contributor

@colemanw can you check this - seems surprising we would need sortable as an id but ..... (I think it's datatables)

@magnolia61
Copy link
Contributor Author

I based this correction on other places in the code where it is also used (with id instead of class).
And a final argument to merge this one. It works and saves us a lot of time editing the templates ;-)

@eileenmcnaughton
Copy link
Contributor

What a compelling case :-) OK

@eileenmcnaughton eileenmcnaughton merged commit e5f300a into civicrm:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants