Get title for event tell a friend mail #12699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
Jenkins ok to test |
|
This seems safe enough & only appears to affect one form - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When using the Tell-a-Friend by mail option I found that the event title wasn't appearing in the mail subject.
See Issue https://lab.civicrm.org/dev/core/issues/344
Before
Sent mail has a title like: "Jo Bloggs wants you to know about"
ie without the event title appended
After
Sent mail has a title like: "Jo Bloggs wants you to know about Special Training Day"
ie with event title
Technical Details
The added code simply retrieves the title in the event case.
The code unnecessarily tries to get the contribution details first and then, if an event, gets the event info. Ideally the code would switch on $pcomponent. However my PR contains the simplest fix.
Comments
Tested on 5.4.0 in WordPress