NFC cleanup to Membership/Renewal form classes. #12696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
matt_1
branch
from
92665ac
to
c26225d
Compare
| @@ -1456,8 +1460,8 @@ public function submit() { | |||
| } | |||
| } | |||
|
|
|||
| if ($formValues['payment_status_id'] != array_search('Completed', $allContributionStatus)) { | |||
| $params['status_id'] = array_search('Pending', $allMemberStatus); | |||
| if ($paymentStatus !== 'Completed') { | |||
There was a problem hiding this comment.
@mattwire this PR is your code - except I added a few lines to the test that failed when re-running it & I altered this line - setting paymentStatus at the point it becomes available & using it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code tidy up - partial reviewer's commit of #12651
Before
code messier
After
code tidier
Technical Details
This is a partial reviewer's commit. Not all code in the original has been reviewed
Comments