dev/joomla#2 Joomla on Windows cli.php & cron.php fail due to incorrect path

[andrewpthompson]

Overview

Ref: https://civicrm.stackexchange.com/questions/24867/compatibility-problem-with-joomla-3-8-7-and-civicrm-5-0-1-that-affects-cron

A hard-coded forward slash resulted in incorrect path on Windows, affecting cli.php and cron.php, with this error:

require(C:\Apache24\htdocs\joomla\administrator\components\com_civicrm\civicrm\administrator\includes\defines.php): failed to open stream: No such file or directory in C:\Apache24\htdocs\joomla\administrator\components\com_civicrm\civicrm\CRM\Utils\System\Joomla.php on line 559

This patch changes the / to DIRECTORY_SEPARATOR

Before

The above error will be produced and cron jobs fail.

After

cron jobs run successfully.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This looks right to me ping @lcdservices @mattwire

[eileenmcnaughton]

yeah - I'm pretty confident that is correct.