Add test for new rounded money format functions #12689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that there are also some protected functions added. I have left those to be teste via this wrapper as they are not yet exposed
|
(Standard links)
|
| /** | ||
| * Test rounded by currency function. | ||
| * | ||
| * This should be formatted according to European standards - . thousand separator |
There was a problem hiding this comment.
@eileenmcnaughton this comment doesn't seem to match the text which seems to be using , as a thousand separator and . as decimal
There was a problem hiding this comment.
doesn't it $this->assertEquals('8.950,37', $result);
There was a problem hiding this comment.
it looks to me to be $this->assertEquals('8,950.37', $result);
There was a problem hiding this comment.
Ah yeah - what I had locally wasn't properly pushed
There was a problem hiding this comment.
ok test looks right now
eileenmcnaughton
force-pushed
the
money_fn
branch
from
75c79fc
to
b8b8e60
Compare
|
This only affects tests so the only judge that really matters is Jenkins, adding merge on pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unit tests in support of #12626
Before
Untested
After
tested
Technical Details
Note that there are also some protected functions added. I have left those to be teste via this wrapper as they are not yet exposed
Comments
@mattwire @seamuslee001 ping