Fix Job Log entries containing links so they will display properly #12659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the message was truncated, but this causes issues if the message included HTML tags. This change strips HTML tags from the message before truncation. The description is limited to 240 characters and has an ellipsis added if it is truncated.
|
(Standard links)
|
|
@seamuslee001 @colemanw what do you think? I'm inclined to think we should just remove the lines in CRM_Utils_Address_BatchUpdate that add the link if we are going to then strip them out of our primary supported UI for these jobs. The function is only called from the api |
|
Why are we trimming the string in the first place? This isn't Twitter. |
|
@colemanw the description column is a varchar255 and comment is |
|
Ok I believe this is better in than out, as it fixes the breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the display of JobLog entries when they contains links
Before
The geocode job provides links in it's message to help users fix unparseable addresses. These appear in the description, but because the description is truncated, the links get broken and the entry doesn't display properly (in this image the whole of the message has become a link).
After
All HTML tags are stripped from the message before it is truncated to form the description
Technical Details
Nil
Comments
The description is limited to 240 characters and has an ellipsis added if it is truncated. It does it in a better way than the original code ;-)