Upgrading multilingual site causes DB Error

[chamilwijesooriya]

GitLab Issue 311 - Upgrading multilingual site causes DB Error

Overview

Upgrading from CiviCRM 4.4.7 to 5.4.0 (Drupal), cause a DB error. Upgrade process works fine.

Before

When loading any civi page, JavaScript error is displayed on the language file (backtrace displayed after enabling).

Checking the error log, few fields relating to uf_group are not getting created during the upgrade.

Further investigation showed that in CRM/Core/I18n, there have been schema changes between the latest SchemaStructure.php and SchemaStructure_4_7_alpha1.php

After

Copied CRM/Core/I18n/SchemaStructure.php and renamed to SchemaStructure_5_4_alpha1.php

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Just as a general pattern - we have been removing the & in lines like above for a while now. It's there in old code so I understand you copying it in - but we don't think it's a good thing

[eileenmcnaughton]

How does this work?

Note that in 4.7.31 a new multilingual field was added - for multilingual upgraders running the api
System.rebuildmultilingualschema should work - not ideal but....

@seamuslee001 @mlutfy thoughts

[mlutfy]

This would explain why we need to run rebuildmultilingualschema after upgrades. It's possible that the new DB Schema does not get loaded by the upgrader, so when it rebuilds the schema, it does not include the frontend_title in the view.

It might have been better to name it SchemaStructure_4_7_31.php, but since we don't support old versions anyway, this isn't a big deal.

[chamilwijesooriya]

@eileenmcnaughton oh didn't know about the API call.. couldn't find in the docs

I just followed what's mentioned in the docs here

and I guess this is the code where it choses which schema structure to load in CRM/Core/I18n/Schema.php

[eileenmcnaughton]

@chamilwijesooriya wow - I had no idea that was there - did you @seamuslee001 @mlutfy

[eileenmcnaughton]

@seamuslee001 I think this is mergeable ....

[mlutfy]

Seems OK to me as well

[seamuslee001]

Seems sensible to me, I say we merge it

[colemanw]

If it's a regression, should it go in 5.5?

[eileenmcnaughton]

@colemanw it's not a recent regression - it has affected the whole 5.x series as it was 4.7.31