Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/cloud-native/issues#18: Soften messages for read-only extensionsDir #12623

Closed
wants to merge 2 commits into from
Closed

dev/cloud-native/issues#18: Soften messages for read-only extensionsDir #12623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f23c5c2
soften messages in checkDirsWritable()
tiotsop01 Aug 4, 2018
251dcce
soften messages in checkDirsWritable()
tiotsop01 Aug 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CRM/Utils/Check/Component/Env.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,16 +453,16 @@ public function checkDirsWritable() {
if (!empty($notWritable)) {
$messages[] = new CRM_Utils_Check_Message(
__FUNCTION__,
ts('The %1 is not writable. Please check your file permissions.', array(
ts('The %1 is not writable. Writing to Settings file has been disabled by admin. Please check your file permissions.', array(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @eileenmcnaughton that this text "writing to Settings file has been disabled by admin" is confusing. This warning can appear in several situations, but I don't think any of them involve writing to a settings file.

1 => implode(', ', $notWritable),
'count' => count($notWritable),
'plural' => 'The following directories are not writable: %1. Please check your file permissions.',
'plural' => 'The following directories are not writable: %1. Writing to Settings file has been disabled by admin. Please check your file permissions.',
)),
ts('Directory not writable', array(
'count' => count($notWritable),
'plural' => 'Directories not writable',
)),
\Psr\Log\LogLevel::ERROR,
\Psr\Log\LogLevel::NOTICE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain an error: it's a real problem if CiviCRM can't upload import files, images, or custom files. In nearly all cases, a site that can't write to these folders will appear "broken" to someone trying to do regular tasks like running imports or uploading a file to a custom field.

'fa-ban'
);
}
Expand Down Expand Up @@ -564,7 +564,7 @@ public function checkExtensions() {
ts('Your extensions directory (%1) is read-only. If you would like to perform downloads or upgrades, then change the file permissions.',
array(1 => $basedir)),
ts('Read-Only Extensions'),
\Psr\Log\LogLevel::WARNING,
\Psr\Log\LogLevel::NOTICE,
'fa-plug'
);
return $messages;
Expand Down