Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contact name into a link on Manage Case for single client #12619

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Aug 3, 2018

Overview

This makes it consistent with multiple clients assigned to the case. Without this there is no direct link back to the client contact record.

Before

localhost_8000_civicrm_contact_view_case_contact_name

After

localhost_8000_civicrm_contact_view_case_contact_link

Technical Details

Single line change to a template

@civibot
Copy link

civibot bot commented Aug 3, 2018

(Standard links)

@@ -60,7 +60,7 @@
<table class="form-layout-compressed">
{foreach from=$caseRoles.client item=client}
<tr class="crm-case-caseview-display_name">
<td class="label-left bold" style="padding: 0px; border: none;">{$client.display_name}</td>
<a href="{crmURL p='civicrm/contact/view' q="action=view&reset=1&cid=`$client.contact_id`"}" title="{ts}View contact record{/ts}">{$client.display_name}</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is valid html to have a <tr> without a <td> inside it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No... I didn't mean to remove the <td> - now fixed.

@colemanw
Copy link
Member

colemanw commented Aug 8, 2018

Looks great.

@colemanw colemanw merged commit 04659e5 into civicrm:master Aug 8, 2018
@mattwire mattwire deleted the caseview_contactlink branch September 25, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants