Further removal of instance of using LOWER() rather than relying on mysql non-case-sensitivity. #12612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
test this please |
colemanw
reviewed
Aug 2, 2018
CRM/Contact/BAO/Query.php
Outdated
| @@ -2253,6 +2255,7 @@ public function restWhere(&$values) { | |||
| ); | |||
| } | |||
| elseif ($name === 'addressee') { | |||
| CRM_Core_Error::deprecatedFunctionWarning('pass in addressee_id or ddressee_display'); | |||
There was a problem hiding this comment.
yeah - but probably no-one will ever see that notice again until they go to remove the code....
There was a problem hiding this comment.
@colemanw ok - fixed
eileenmcnaughton
force-pushed
the
more_lower
branch
from
553a5bc
to
884e1ee
Compare
|
test this please |
|
@monishdeb @seamuslee001 @lcdservices @colemanw this passed - am wondering if anyone else can figure out a way to hit these deprecation notices or whether it's truly dead code. I think this is mergeable as we have proven the concept of removing 'LOWER' we are just actioning it conservatively |
|
opps I can see a comment to remove - that will trigger tests again :-( |
…ysql non-case-sensitivity. Note I could not find any way to call this so I added deprecation notices Per civicrm#12494 the use of LOWER hurts performance fails to return results on some char sets messes with REGEX This is part of a continued (we removed from contribution search fields last year) staggered approach to removing this old mechanism
eileenmcnaughton
force-pushed
the
more_lower
branch
from
884e1ee
to
b7aa36b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is part of a phased process of removing LOWER from core mysql queries. So far we are only aware of downsides to using it but out of cautiousness are removing it slowly over releases
Before
Calls to filter on email_greeting, postal_greeting, address have LOWER applied (resulting in unindexed searches)
After
LOWER not applied, mysql case insensitive search relied on
Technical Details
Per #12494 & # 12503 the use of LOWER
hurts performance
fails to return results on some char sets
messes with REGEX
This is part of a continued (we removed from contribution search fields last year)
staggered approach to removing this old mechanism
Comments
Note I could not find any way to hit this line of code so I added deprecation notices. I looked in advanced search, search builder, api explorer & I created a search profile per the screen shot