Customvalue ID is ignored

[monishdeb]

Overview

Earlier the ID of custom value table's record was not considered and thus it doesn't allow to update a custom table value record.

Before

Doesn't update the custom table value

After

Update the custom table value

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@monishdeb a few lines down from your patch I see

if ($fieldValue['id'] > 0) {
  $cvParam['id'] = $fieldValue['id'];
}

So perhaps there is an alternate way of passing in the id to this function from api4 which you could use instead that would not require this PR?

[monishdeb]

@colemanw yes I saw that earlier, but found the spot how the $fieldValue['id'] is assigned, because in the query above https://github.com/civicrm/civicrm-core/pull/12606/files#diff-927e742818deb9c89a00d2528e360bf0R577 there is no indication that id is retrieved nor it searches $params.

[colemanw]

This passes tests and fixes a failing test in Api4.

[monishdeb]

Thanks @colemanw