dev/core#295 - Allow default 'from' email to be set in New email form #12603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@mattwire @seamuslee001 I feel like you have been involved in this |
mattwire
requested changes
Aug 3, 2018
There was a problem hiding this comment.
@jitendrapurohit I've reproduced the issue and agree we should fix it. But can you modify your code per my comments?
| $form->_fromEmails = $fromEmailValues; | ||
| if (!Civi::settings()->get('allow_mail_from_logged_in_contact')) { | ||
| $defaults['from_email_address'] = key(CRM_Core_OptionGroup::values('from_email_address', TRUE, NULL, NULL, ' AND is_default = 1')); |
There was a problem hiding this comment.
Ok, we shouldn't be calling CRM_Core_OptionGroup::values directly here. I think the correct function to use would be CRM_Core_BAO_Domain::getNameAndEmail() from here: https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/BAO/Domain.php#L172
There was a problem hiding this comment.
Thanks @mattwire Updated the PR with the above function replacement.
jitendrapurohit
force-pushed
the
core-295
branch
from
ef582a5
to
7a7019f
Compare
|
test this please |
|
@mattwire can you recheck |
|
Thanks @mattwire @jitendrapurohit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allow default from email address to be set as default on the "New Email" form.
Before
Default From address is not loaded as default on the email form.
SE Post - https://civicrm.stackexchange.com/questions/25562/why-does-the-default-from-email-address-not-show-as-the-first-option-when-usin
After
If
Allow Mail to be sent from logged in contact's email addressis disabled in settings, defaultfromaddress is loaded on the form.Gitlab issue - https://lab.civicrm.org/dev/core/issues/295