Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Export - don't pass arrays as reference when they are not changed #12596

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor export code tidy up

Before

Arrays passed as reference, but not changed so no gain by doing so

After

Arrays not passed as reference

Technical Details

Comments

@seamuslee001 this should be an easy one to check & hopefully give merge on pass

@civibot
Copy link

civibot bot commented Jul 30, 2018

(Standard links)

@seamuslee001
Copy link
Contributor

Agree no reason for these things to be passed by reference when not modified no sign of hooks altering it either. Adding merge on pass

@eileenmcnaughton eileenmcnaughton merged commit 315dbc2 into civicrm:master Jul 30, 2018
@eileenmcnaughton eileenmcnaughton deleted the export_ref branch July 30, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants