API : Set current domain as a sensible default for payment processor #12595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -56,7 +56,6 @@ function _civicrm_api3_payment_processor_type_create_spec(&$params) { | |||
| $params['class_name']['api.required'] = 1; | |||
| $params['is_active']['api.default'] = 1; | |||
| $params['is_recur']['api.default'] = FALSE; | |||
| // FIXME bool support // $params['is_recur']['api.required'] = 1; | |||
There was a problem hiding this comment.
This line seemed meaningless to me so removed it at the same time
|
@colemanw can you merge this? |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Change api PaymentProcessor.create action such that domain_id is optional. When id is not present use the current domain as a default.
Before
Fails as domain_id is mandatory
After
Above passes & current domain id is used.
Technical Details
This is consistent with other api - e.g Navigation.
Comments