Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Fix regression on case export" to 5.4 #12588

Merged
merged 2 commits into from
Jul 28, 2018

Conversation

mattwire
Copy link
Contributor

Overview

Ref #12517 Case Export was crashing

Before

See #12517

After

See #12517

Comments

@lcdservices Don't suppose you have time to test this against 5.4rc before the release? @totten When is the release being cut?
@eileenmcnaughton This is your fix, backported to 5.4

@civibot
Copy link

civibot bot commented Jul 28, 2018

(Standard links)

@lcdservices
Copy link
Contributor

@mattwire I ran through tests. I didn't hit any errors. There were some enotices when exporting cases using select fields for export, but they were different from the ones previously reported, so may be unrelated.

However -- when exporting cases using primary fields, I'm seeing a lot of what appear to be duplicate rows. This may be unrelated to the intent of this PR, but is worth noting here.

@eileenmcnaughton
Copy link
Contributor

@lcdservices did you hit an error WITHOUT this patch? ie. is it better WITH?

@lcdservices
Copy link
Contributor

It's better with. There are the previously reported e-notices and a fatal error when exporting cases when running on 5.4 without this patch.

@eileenmcnaughton eileenmcnaughton merged commit 964025e into civicrm:5.4 Jul 28, 2018
@mattwire mattwire deleted the 5.4_backportcasefixes branch September 25, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants