Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] dev/accessibility#10 : Make datepicker accessible #12580

Closed
wants to merge 2 commits into from

Conversation

monishdeb
Copy link
Member

Overview

A user should be able to use datepicker with the help of control keys, not just cursor actions, pretty much similar to this example
https://dequeuniversity.com/library/aria/date-pickers/sf-date-picker

Before

Datepicker widget is not accessible

After

Datepicker widget is accessible via control keys:
test-multiple-after

@civibot
Copy link

civibot bot commented Jul 27, 2018

(Standard links)

@monishdeb
Copy link
Member Author

@colemanw I have moved the datepicker widget code in a separate file and added the handlers for control keys here

Please have a look.

$target.attr(name, $source.attr(name));
}
});
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change this in Common.js to CRM.utils.copyAttribues then you don't need to dupilcate the fn.

@colemanw
Copy link
Member

@monishdeb it would be a lot easier to review this PR if it were split into two commits:

  1. Move datepicker code from Common.js -> new file (with no code changes).
  2. Code changes to make it accessible.

Then I could click on the 2nd commit and see what you've changed in the datepicker code.

@eileenmcnaughton
Copy link
Contributor

@monishdeb test fail relates

@eileenmcnaughton
Copy link
Contributor

@monishdeb let's close this for now & replace with a PR that moves the code to the new file as the next step & then follow up - per comments above

@eileenmcnaughton
Copy link
Contributor

@monishdeb what is the status now? Looks like you maybe rebased after the last comment

@eileenmcnaughton
Copy link
Contributor

test this please

@Clairepickle
Copy link

tried to use on test site in Safari, new date picker inconsistently available from create new menu, also can't seem to get functionality to work as in example supplied - tabbing into picker selects today's date but unable to change value, further tab takes to month and year drop downs but down arrow does not open these as would expect, also prevents user typing date directly as in current picker which is the usual method for visually impaired users, could further usage instructions be provided?

@monishdeb
Copy link
Member Author

Thanks @Clairepickle for your feedback. I will work further in this PR to mimic the accessible datepicker presented in https://dequeuniversity.com/library/aria/date-pickers/sf-date-picker Feel free to suggest any other accessible options which is not present in the example. I am marking this PR with WIP

@monishdeb monishdeb changed the title dev/accessibility#10 : Make datepicker accessible [WIP] dev/accessibility#10 : Make datepicker accessible Oct 10, 2018
@seamuslee001
Copy link
Contributor

@monishdeb @colemanw where are we at with this?

@eileenmcnaughton
Copy link
Contributor

@monishdeb this one is stale :-( Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants