-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] dev/accessibility#10 : Make datepicker accessible #12580
Conversation
(Standard links)
|
js/crm.datepicker.js
Outdated
$target.attr(name, $source.attr(name)); | ||
} | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change this in Common.js to CRM.utils.copyAttribues
then you don't need to dupilcate the fn.
@monishdeb it would be a lot easier to review this PR if it were split into two commits:
Then I could click on the 2nd commit and see what you've changed in the datepicker code. |
@monishdeb test fail relates |
@monishdeb let's close this for now & replace with a PR that moves the code to the new file as the next step & then follow up - per comments above |
41134fd
to
14214b5
Compare
@monishdeb what is the status now? Looks like you maybe rebased after the last comment |
test this please |
tried to use on test site in Safari, new date picker inconsistently available from create new menu, also can't seem to get functionality to work as in example supplied - tabbing into picker selects today's date but unable to change value, further tab takes to month and year drop downs but down arrow does not open these as would expect, also prevents user typing date directly as in current picker which is the usual method for visually impaired users, could further usage instructions be provided? |
Thanks @Clairepickle for your feedback. I will work further in this PR to mimic the accessible datepicker presented in https://dequeuniversity.com/library/aria/date-pickers/sf-date-picker Feel free to suggest any other accessible options which is not present in the example. I am marking this PR with WIP |
@monishdeb @colemanw where are we at with this? |
@monishdeb this one is stale :-( Closing for now |
Overview
A user should be able to use datepicker with the help of control keys, not just cursor actions, pretty much similar to this example
https://dequeuniversity.com/library/aria/date-pickers/sf-date-picker
Before
Datepicker widget is not accessible
After
Datepicker widget is accessible via control keys:
![test-multiple-after](https://camo.githubusercontent.com/90376bffad1d8d247d21b98d740039650370f09aea2cbd22a18c44ec4cc1d2c8/68747470733a2f2f6c61622e6369766963726d2e6f72672f6465762f6163636573736962696c6974792f75706c6f6164732f64663238386166613535363738313338323430303733613662623163373364632f746573742d6d756c7469706c652d61667465722e676966)