Export clean up sql columns #12577
Merged
Export clean up sql columns #12577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton looks like some whitespace issues. https://test.civicrm.org/job/CiviCRM-Core-PR/21850/checkstyleResult/new/ Otherwise I think we're good to merge this on pass. |
Note that I wrote test coverage that was pretty extensive on the output of this function earlier
eileenmcnaughton
force-pushed
the
export_sql_columns
branch
from
8dd2049 to
c8adad8
Compare
|
Merging as per the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup - heavy test coverage previously committed
Before
Code part of the borg
After
Code has it's own function
Technical Details
This is HEAVILY tested -from recent preparatory additions - see
https://github.com/civicrm/civicrm-core/blob/master/tests/phpunit/CRM/Export/BAO/ExportTest.php#L614-L692
and
https://github.com/civicrm/civicrm-core/blob/master/tests/phpunit/CRM/Export/BAO/ExportTest.php#L1325-L1795
Comments
Bigger picture of this cleanup is currently at #12575