dev/279 - When Merging two contacts flip, prev, next not working #12568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affects Joomla and WordPress Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>
|
(Standard links)
|
|
unrelated fail |
yashodha
referenced
this pull request
in cividesk/civicrm-core
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects Joomla and WordPress
Signed-off-by: Kevin Cristiano kcristiano@tadpole.cc
Overview
When Merging two contacts, Prreevios, Next, and Flip between original and duplicate link not working in Joomla and WordPress
Before
When clicking in the links for previous, next, or flip the user would be redirected to the CiviCRM home page
After
When clicking on the links the user gets the expected behavior
Technical Details
see https://lab.civicrm.org/dev/core/issues/279 and https://chat.civicrm.org/civicrm/pl/inrp143b7jgxmboqozdnxprqae
From Eileen's comments on the issue: "Have discussed with Kevin on chat - basically our function CRM_Utils_System::url is deeply inconsistent :-( If it is passed a query it url_encodes the keys & values and to escape in smarty would be wrong."
Comments