(dev/core#217) CRM_Utils_Cache_Redis::connect() - Allow pooling connections #12544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions Before ------ * Every time you create an instance of `CRM_Utils_Cache_Redis`, it makes a new instance of the driver class `Redis`. After ----- * Every time you create an instance of `CRM_Utils_Cache_Redis`, it uses a shared instance of the driver class `Redis` (assuming the host/port are the same). * If you're writing a driver somewhere else (e.g. the upcomgin `CRM_Core_PrevNextCache_Redis`), you can use the shared instance of `Redis`.
|
(Standard links)
|
|
I tested this locally & stepped through & Redis still loads fine with this change. I tested without a password but reading the code the change on with-password is pretty cosmetic - merge on pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In a world with
CRM/Utils/Cache/Redis.phpand the (upcoming)CRM/Core/PrevNextCache/Redis.php, there would be two classes which need access to the same Redis connection. This allows each one to request a connection -- but only one connection will really be made.This is a cherry-pick of some commits from #12377.
See also: dev/core#217
Before
CRM_Utils_Cache_Redis, it makes a new instance of the driver classRedis.After
CRM_Utils_Cache_Redis, it uses a shared instance of the driver classRedis(assuming the host/port are the same).CRM_Core_PrevNextCache_Redis), you can use the shared instance ofRedis.