Fix signature on BAO_Product::add to make ids optional

[eileenmcnaughton]

Overview

Fix signature on BAO_Product::add to make ids optional

Partial reviewer's commit from #12437 but I went a bit further with removing $ids from the signature

Before

$ids is a required field on Product::add - which is inconsistent with our standards

After

$ids is removed. $params is not passed as reference - this is our preferred signature

Technical Details

Since the BAO_Product::add function is new we don't need to support $ids. The only code place we call this is

  $premium = CRM_Contribute_BAO_Product::add($params);

    CRM_Core_Session::setStatus(
      ts("The Premium '%1' has been saved.", array(1 => $premium->name)),
      ts('Saved'), 'success');
  }

so we don't need the (non-std) behaviour of passing $params as a reference

I also renamed BAO_Product::add to create (which is a bit more standard) so it would not have to have the same signature as ManagePremiums which inherits

Comments

@mattwire can you OK my additional change here

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[JoeMurray]

I agree in principal with the changes introduced by Eileen.

[colemanw]

@eileenmcnaughton one style error:

Product.php:92, ParamNameNoMatch, Priority: High
--
Doc comment for parameter $ids does not match actual variable name