Expose UI support for custom fields on financial types

[pradpnayak]

Overview

https://lab.civicrm.org/dev/financial/issues/29

Before

Custom fields were not supported for Financial Type

After

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[pradpnayak]

Can anyone please review this for me?

[eileenmcnaughton]

I haven't reviewed but I peeked at the code & the coding approach taken here is consistent with the work we have been doing in this area.

[eileenmcnaughton]

@pradpnayak the one issue I have with this is that you are enabling custom fields out of the box. My position so far has been that we should make it possible for extensions to enable these but not do it in core.

My main concern with enabling in core is it sets expectations that we then accept things like making the data available in searches / reports etc & that is a whole extra conversation. I think we should remove that part before we merge it & discuss separately (ok to leave in for now as it might make it easier for a reviewer)

[pradpnayak]

@eileenmcnaughton I need a help!!

How i can place the div section for button just besides the Save and Cancel buttom? Can i use JS to move the link or will i need to CRM/Core/Form/EntityForm.tpl to include sections insertions?

[eileenmcnaughton]

This seems ok?

[pradpnayak]

When you open in a new tab the 'View or Edit Financial Accounts' button goes below of Save and Cancel

[eileenmcnaughton]

Does overriding protected function addFormButtons() { help?

[eileenmcnaughton]

buttons look ok for me

[pradpnayak]

Its a link not a button actually. When i open in a new tab(right click new tab) i can see buttons not in line. But incase of pop-up it does.

[eileenmcnaughton]

hmm not sure maybe @colemanw has a good idea

I guess we could have an 'inner tpl' of

  {if $action eq 8}
    <div class="messages status no-popup">
      <div class="icon inform-icon"></div>
      {$deleteMessage|escape}
    </div>
  {else}
    <table class="form-layout-compressed">
      {foreach from=$entityFields item=fieldSpec}
        {assign var=fieldName value=$fieldSpec.name}
        <tr class="crm-{$entityInClassFormat}-form-block-{$fieldName}">
          {include file="CRM/Core/Form/Field.tpl"}
        </tr>
      {/foreach}
    </table>
    {include file="CRM/common/customDataBlock.tpl"}
  {/if}

that is included from CRM/Core/Form/EntityForm.tpl - so you can just include the inner if you want ... different buttons

[pradpnayak]

@eileenmcnaughton I have updated the PR to include only form changes and moved installation code to an extension.

[eileenmcnaughton]

@pradpnayak I tested this in view and edit mode and read through the code. I'm OK to merge this aside from your button alignment issue & I'm OK with that as a follow up too.

[eileenmcnaughton]

test this please

[pradpnayak]

Thanks @eileenmcnaughton